diff options
| author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2008-02-20 20:51:45 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-04-24 21:16:39 -0700 |
| commit | e298449401463dd18f24a87c48f9b0ec62bad936 (patch) | |
| tree | 12f84e1370d9e81b15f742dfba1ee5b3b60ef108 | |
| parent | 9b0f2582d57d4c9081307c86e11afc9169de7d3e (diff) | |
USB: serial: Note mos7480 and option don't lock modem status
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 1 | ||||
| -rw-r--r-- | drivers/usb/serial/option.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index aeeb9cb2099..0b29c5383dc 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -1722,6 +1722,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file, if (mos7840_port == NULL) return -ENODEV; + /* FIXME: What locks the port registers ? */ mcr = mos7840_port->shadowMCR; if (clear & TIOCM_RTS) mcr &= ~MCR_RTS; diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d101025a4c6..0e7eeb2820e 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -458,6 +458,7 @@ static int option_tiocmset(struct usb_serial_port *port, struct file *file, portdata = usb_get_serial_port_data(port); + /* FIXME: what locks portdata fields ? */ if (set & TIOCM_RTS) portdata->rts_state = 1; if (set & TIOCM_DTR) |