diff options
| author | Andrew de Quincey <adq_dvb@lidskialf.net> | 2006-08-08 09:10:11 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2006-09-26 11:53:32 -0300 |
| commit | 8b9a46647b965f7033c198dd5e73d58b10e22a21 (patch) | |
| tree | 1f162c9868f0473524a60d65ee8c66b29e2f2588 | |
| parent | 2b100e7d3c448dd369cf36ff38844b2440fab49d (diff) | |
V4L/DVB (4403): Use dprintk in tda826x.
As opposed to printk() at the moment, which will fill logs uselessly
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
| -rw-r--r-- | drivers/media/dvb/frontends/tda826x.c | 22 |
1 files changed, 17 insertions, 5 deletions
diff --git a/drivers/media/dvb/frontends/tda826x.c b/drivers/media/dvb/frontends/tda826x.c index f594eab4432..7c19b88e950 100644 --- a/drivers/media/dvb/frontends/tda826x.c +++ b/drivers/media/dvb/frontends/tda826x.c @@ -26,6 +26,12 @@ #include "tda826x.h" +static int debug = 0; +#define dprintk(args...) \ + do { \ + if (debug) printk(KERN_DEBUG "tda826x: " args); \ + } while (0) + struct tda826x_priv { /* i2c details */ int i2c_address; @@ -49,17 +55,18 @@ static int tda826x_sleep(struct dvb_frontend *fe) u8 buf [] = { 0x00, 0x8d }; struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 2 }; + dprintk("%s:\n", __FUNCTION__); + if (!priv->has_loopthrough) buf[1] = 0xad; if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 1); if ((ret = i2c_transfer (priv->i2c, &msg, 1)) != 1) { - printk("%s: i2c error\n", __FUNCTION__); + dprintk("%s: i2c error\n", __FUNCTION__); } if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 0); - printk("%s:\n", __FUNCTION__); return (ret == 1) ? 0 : ret; } @@ -72,6 +79,8 @@ static int tda826x_set_params(struct dvb_frontend *fe, struct dvb_frontend_param u8 buf [11]; struct i2c_msg msg = { .addr = priv->i2c_address, .flags = 0, .buf = buf, .len = 11 }; + dprintk("%s:\n", __FUNCTION__); + div = (params->frequency + (1000-1)) / 1000; buf[0] = 0x00; // subaddress @@ -91,13 +100,12 @@ static int tda826x_set_params(struct dvb_frontend *fe, struct dvb_frontend_param if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 1); if ((ret = i2c_transfer (priv->i2c, &msg, 1)) != 1) { - printk("%s: i2c error\n", __FUNCTION__); + dprintk("%s: i2c error\n", __FUNCTION__); } if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 0); priv->frequency = div * 1000; - printk("%s:\n", __FUNCTION__); return (ret == 1) ? 0 : ret; } @@ -128,6 +136,8 @@ struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, struct i2 struct i2c_msg msg [] = { { .addr = addr, .flags = I2C_M_RD, .buf = b1, .len = 2 } }; int ret; + dprintk("%s:\n", __FUNCTION__); + if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 1); ret = i2c_transfer (i2c, msg, 1); @@ -150,12 +160,14 @@ struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, struct i2 memcpy(&fe->ops.tuner_ops, &tda826x_tuner_ops, sizeof(struct dvb_tuner_ops)); fe->tuner_priv = priv; - printk("%s:\n", __FUNCTION__); return fe; } EXPORT_SYMBOL(tda826x_attach); +module_param(debug, int, 0644); +MODULE_PARM_DESC(debug, "Turn on/off frontend debugging (default:off)."); + MODULE_DESCRIPTION("DVB TDA826x driver"); MODULE_AUTHOR("Andrew de Quincey"); MODULE_LICENSE("GPL"); |