aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRusty Russell <rusty@rustcorp.com.au>2008-03-13 09:03:44 +0000
committerRusty Russell <rusty@rustcorp.com.au>2008-05-01 21:14:59 +1000
commita58730c42174672fe0012a4edbe3e38f94ef2bad (patch)
tree6cd01098614ea8fc00f5eba462a208cc5a038d2a
parente4c576b911e364737b1bf4f5bfdab1c440713f26 (diff)
module: make module_sect_attrs private to kernel/module.c
No-one else is using these afaics. Signed-off-by: Jan Beulich <jbeulich@novell.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-rw-r--r--include/linux/module.h17
-rw-r--r--kernel/module.c16
2 files changed, 15 insertions, 18 deletions
diff --git a/include/linux/module.h b/include/linux/module.h
index 819c4e889bf..a29c2ebb7c3 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -229,23 +229,6 @@ enum module_state
MODULE_STATE_GOING,
};
-/* Similar stuff for section attributes. */
-struct module_sect_attr
-{
- struct module_attribute mattr;
- char *name;
- unsigned long address;
-};
-
-struct module_sect_attrs
-{
- struct attribute_group grp;
- int nsections;
- struct module_sect_attr attrs[0];
-};
-
-struct module_param_attrs;
-
struct module
{
enum module_state state;
diff --git a/kernel/module.c b/kernel/module.c
index 8d6cccc6c3c..b0d7c2a41bd 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -991,6 +991,20 @@ static unsigned long resolve_symbol(Elf_Shdr *sechdrs,
* J. Corbet <corbet@lwn.net>
*/
#if defined(CONFIG_KALLSYMS) && defined(CONFIG_SYSFS)
+struct module_sect_attr
+{
+ struct module_attribute mattr;
+ char *name;
+ unsigned long address;
+};
+
+struct module_sect_attrs
+{
+ struct attribute_group grp;
+ unsigned int nsections;
+ struct module_sect_attr attrs[0];
+};
+
static ssize_t module_sect_show(struct module_attribute *mattr,
struct module *mod, char *buf)
{
@@ -1001,7 +1015,7 @@ static ssize_t module_sect_show(struct module_attribute *mattr,
static void free_sect_attrs(struct module_sect_attrs *sect_attrs)
{
- int section;
+ unsigned int section;
for (section = 0; section < sect_attrs->nsections; section++)
kfree(sect_attrs->attrs[section].name);