aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorakpm@osdl.org <akpm@osdl.org>2006-01-09 20:51:40 -0800
committerLinus Torvalds <torvalds@g5.osdl.org>2006-01-10 08:01:26 -0800
commit82409411571ad89d271dc46f7fa26149fad9efdf (patch)
tree3e7523c55a2d883f2a7d9ac3285ed6ebb864fb1b
parentaed615a95f6dcc243daa99cc80658ad9ada95097 (diff)
[PATCH] kdump: i386 save ss esp bug fix
) From: Vivek Goyal <vgoyal@in.ibm.com> This patch fixes a minor bug based on Andi Kleen's suggestion. asm's can't be broken in this particular case, hence merging them. Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--arch/i386/kernel/crash.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c
index 0248e084017..10fe6569751 100644
--- a/arch/i386/kernel/crash.c
+++ b/arch/i386/kernel/crash.c
@@ -108,8 +108,10 @@ static void crash_setup_regs(struct pt_regs *newregs, struct pt_regs *oldregs)
{
memcpy(newregs, oldregs, sizeof(*newregs));
newregs->esp = (unsigned long)&(oldregs->esp);
- __asm__ __volatile__("xorl %eax, %eax;");
- __asm__ __volatile__ ("movw %%ss, %%ax;" :"=a"(newregs->xss));
+ __asm__ __volatile__(
+ "xorl %%eax, %%eax\n\t"
+ "movw %%ss, %%ax\n\t"
+ :"=a"(newregs->xss));
}
/* We may have saved_regs from where the error came from