diff options
| author | James Morris <jmorris@namei.org> | 2006-04-26 02:45:03 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-04-26 07:52:21 -0700 |
| commit | e7edf9cdeddc0cff125e8e658216efb2ff2b2219 (patch) | |
| tree | 4a7c5c915a5d44a14f32261ada050021d91e3e56 | |
| parent | a090d9132c1e53e3517111123680c15afb25c0a4 (diff) | |
[PATCH] LSM: add missing hook to do_compat_readv_writev()
This patch addresses a flaw in LSM, where there is no mediation of readv()
and writev() in for 32-bit compatible apps using a 64-bit kernel.
This bug was discovered and fixed initially in the native readv/writev
code [1], but was not fixed in the compat code. Thanks to Al for spotting
this one.
[1] http://lwn.net/Articles/154282/
Signed-off-by: James Morris <jmorris@namei.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | fs/compat.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/compat.c b/fs/compat.c index 7f8e26ea427..2e32bd34047 100644 --- a/fs/compat.c +++ b/fs/compat.c @@ -1217,6 +1217,10 @@ static ssize_t compat_do_readv_writev(int type, struct file *file, if (ret < 0) goto out; + ret = security_file_permission(file, type == READ ? MAY_READ:MAY_WRITE); + if (ret) + goto out; + fnv = NULL; if (type == READ) { fn = file->f_op->read; |