aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2006-05-15 20:58:30 +0900
committerTejun Heo <htejun@gmail.com>2006-05-15 20:58:30 +0900
commit2a3917a8bb40a2cb75b458da9c356e8557e8fbed (patch)
tree8899c9447b35c5fb00ce272837fd733df7c5aa35
parent78cd52d02fa0735949a9fa30a6b79bf02c94c250 (diff)
[PATCH] ahci: add PIOS interim interrupt handling
During multiblock PIO, multiple PIOS interrupts are generated before qc compltion. Current code prints unnecessary message for such cases. This is exposed when new EH slows down attached device into PIO mode. Signed-off-by: Tejun Heo <htejun@gmail.com>
-rw-r--r--drivers/scsi/ahci.c13
1 files changed, 12 insertions, 1 deletions
diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index d6894bd6798..35487e30b0f 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -883,7 +883,18 @@ static void ahci_host_intr(struct ata_port *ap)
}
}
- /* spurious interrupt */
+ /* hmmm... a spurious interupt */
+
+ /* ignore interim PIO setup fis interrupts */
+ if (ata_tag_valid(ap->active_tag)) {
+ struct ata_queued_cmd *qc =
+ ata_qc_from_tag(ap, ap->active_tag);
+
+ if (qc && qc->tf.protocol == ATA_PROT_PIO &&
+ (status & PORT_IRQ_PIOS_FIS))
+ return;
+ }
+
if (ata_ratelimit())
ata_port_printk(ap, KERN_INFO, "spurious interrupt "
"(irq_stat 0x%x active_tag %d)\n",