diff options
| author | H. Peter Anvin <hpa@zytor.com> | 2007-08-22 16:28:01 -0700 |
|---|---|---|
| committer | H. Peter Anvin <hpa@zytor.com> | 2007-08-23 13:03:25 -0700 |
| commit | b015124e562a040f7faf361c72e8f5f457ac6cf5 (patch) | |
| tree | 452f3fe6b9a7d2ef692e021a18f588490bc78441 /arch/i386/boot/video-vga.c | |
| parent | b377fd3982ad957c796758a90e2988401a884241 (diff) | |
[x86 setup] Volatilize asm() statements
asm() statements need to be volatile when:
a. They have side effects (other than value returned).
b. When the value returned can vary over time.
c. When they have ordering constraints that cannot be expressed to gcc.
In particular, the keyboard and timer reads were violating constraint (b),
which resulted in the keyboard/timeout poll getting
loop-invariant-removed when compiling with gcc 4.2.0.
Thanks to an anonymous bug reporter for pointing this out.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/i386/boot/video-vga.c')
| -rw-r--r-- | arch/i386/boot/video-vga.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/arch/i386/boot/video-vga.c b/arch/i386/boot/video-vga.c index 700d09a9c9b..d660e608cd5 100644 --- a/arch/i386/boot/video-vga.c +++ b/arch/i386/boot/video-vga.c @@ -47,16 +47,16 @@ static u8 vga_set_basic_mode(void) #ifdef CONFIG_VIDEO_400_HACK if (adapter >= ADAPTER_VGA) { - asm(INT10 - : : "a" (0x1202), "b" (0x0030) - : "ecx", "edx", "esi", "edi"); + asm volatile(INT10 + : : "a" (0x1202), "b" (0x0030) + : "ecx", "edx", "esi", "edi"); } #endif ax = 0x0f00; - asm(INT10 - : "+a" (ax) - : : "ebx", "ecx", "edx", "esi", "edi"); + asm volatile(INT10 + : "+a" (ax) + : : "ebx", "ecx", "edx", "esi", "edi"); mode = (u8)ax; |