aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorStuart Bennett <stuart@freedesktop.org>2009-03-08 20:21:35 +0200
committerIngo Molnar <mingo@elte.hu>2009-03-08 19:51:23 +0100
commitd0fc63f7bd07cb779a06dc1cdd0c5a14e7f5d562 (patch)
tree9d4dd9976bbc20709d6f8e0242537f76141bdc7d /block
parent73bf1b62f561fc8ecb00e2810efe4fe769f4933e (diff)
x86 mmiotrace: fix remove_kmmio_fault_pages()
Impact: fix race+crash in mmiotrace The list manipulation in remove_kmmio_fault_pages() was broken. If more than one consecutive kmmio_fault_page was re-added during the grace period between unregister_kmmio_probe() and remove_kmmio_fault_pages(), the list manipulation failed to remove pages from the release list. After a second grace period the pages get into rcu_free_kmmio_fault_pages() and raise a BUG_ON() kernel crash. The list manipulation is fixed to properly remove pages from the release list. This bug has been present from the very beginning of mmiotrace in the mainline kernel. It was introduced in 0fd0e3da ("x86: mmiotrace full patch, preview 1"); An urgent fix for Linus. Tested by Stuart (on 32-bit) and Pekka (on amd and intel 64-bit systems, nouveau and nvidia proprietary). Signed-off-by: Stuart Bennett <stuart@freedesktop.org> Signed-off-by: Pekka Paalanen <pq@iki.fi> LKML-Reference: <20090308202135.34933feb@daedalus.pq.iki.fi> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions