diff options
author | David S. Miller <davem@davemloft.net> | 2007-03-01 18:29:14 -0800 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-03-02 15:22:54 -0800 |
commit | 7ab876703dcbe852652db6441f0aadb3d6b75e94 (patch) | |
tree | 4c9f04c21962c5d6a265a4ae0adf19110ea3633e /drivers/ata/pata_hpt3x2n.c | |
parent | c4c31fe0e2298529afa1357ebd9dad54b44c4e19 (diff) |
[RADEON]: Fix blanking return value.
If you'll recall, over a year ago, I pointed out that the current
Radeon driver erroneously returns -EINVAL for valid blanking codes,
here is a link to that thread:
http://lkml.org/lkml/2006/1/28/6
No other driver does this, and it confuses the X server into thinking
that the device does not support blanking properly.
I looked again and there is simply no reason for the Radeon driver to
return -EINVAL for FB_BLANK_NORMAL. It claims it wants to do this in
order to convince fbcon to blank in software, right here:
if (fb_blank(info, blank))
fbcon_generic_blank(vc, info, blank);
to software blank the screen. But it only causes that to happen
in the FB_BLANK_NORMAL case.
That makes no sense because the Radeon code does this:
val |= CRTC_DISPLAY_DIS;
in the FB_BLANK_NORMAL case so should be blanking the hardware, and
there is therefore no reason to SW blank by returning -EINVAL.
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Antonino Daplas <adaplas@gmail.com>
Diffstat (limited to 'drivers/ata/pata_hpt3x2n.c')
0 files changed, 0 insertions, 0 deletions