diff options
author | Mikael Pettersson <mikpe@it.uu.se> | 2008-05-17 18:47:35 +0200 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-05-19 17:30:47 -0400 |
commit | a13db78e2209ebfe1898207f53c353ed836d4a53 (patch) | |
tree | 6e20091316cf2742825ef3f17e8069391657b6f0 /drivers/ata/pata_ixp4xx_cf.c | |
parent | 07633b5d0723ce2ec31262e1096dcf61311bf078 (diff) |
sata_promise: fix irq clearing buglets
This patch fixes two bugs in sata_promise's irq status clearing paths:
1. When clearing the irq status for a specific port, the driver
read the global SEQMASK register. This is wrong because that
clears the irq status for _all_ ports.
2. pdc_thaw() incorrectly added the PDC_INT_SEQMASK host register
offset to a per-port ata engine base address. This resulted in
it reading the unrelated PDC_PKT_SUBMIT register, which did not
have the desired irq status clearing effect.
In both cases the fix is to read from the port's Command/Status
register. This also matches what Promise's own driver does.
Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata/pata_ixp4xx_cf.c')
0 files changed, 0 insertions, 0 deletions