diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2010-01-24 16:45:03 +0100 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2010-01-26 20:54:50 +0100 |
commit | 281e20323ab72180137824a298ee9e21e6f9acf6 (patch) | |
tree | b807edaafec3c00e442d41d9091b9783a53820f9 /drivers/firewire/ohci.c | |
parent | 6d3faf6f431bafb25f4b9926c50a7e5c267738c6 (diff) |
firewire: core: fix use-after-free regression in FCP handler
Commit db5d247a "firewire: fix use of multiple AV/C devices, allow
multiple FCP listeners" introduced a regression into 2.6.33-rc3:
The core freed payloads of incoming requests to FCP_Request or
FCP_Response before a userspace driver accessed them.
We need to copy such payloads for each registered userspace client
and free the copies according to the lifetime rules of non-FCP client
request resources.
(This could possibly be optimized by reference counts instead of
copies.)
The presently only kernelspace driver which listens for FCP requests,
firedtv, was not affected because it already copies FCP frames into an
own buffer before returning to firewire-core's FCP handler dispatcher.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/ohci.c')
0 files changed, 0 insertions, 0 deletions