diff options
author | Julia Lawall <julia@diku.dk> | 2009-08-03 11:11:45 +0200 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-08-03 16:31:22 -0400 |
commit | c37457e69ffd7d3c94cbfcc1c39be9a45dd7ad21 (patch) | |
tree | 3ad0293908238997c93951ab5dadf3876e4a4db7 /drivers/net/de620.h | |
parent | dbc1eec485625228895ded6baf6bd01ce2475410 (diff) |
drivers/net/wireless/iwlwifi: introduce missing kfree
Move orthogonal error handling code up before a kzalloc, so that it
doesn't have to free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/de620.h')
0 files changed, 0 insertions, 0 deletions