diff options
author | Michael Buesch <mb@bu3sch.de> | 2006-10-28 17:52:34 -0500 |
---|---|---|
committer | John W. Linville <linville@laptop.(none)> | 2006-10-31 22:15:40 -0500 |
commit | 81e171b95d2d06a64465a1e6ab1e2fb864ea2448 (patch) | |
tree | 5154832a9d5f54901163f50445324910dcb22d93 /drivers/net/es3210.c | |
parent | 115e222d538e7838bffa0f76409acd9816a0ef32 (diff) |
[PATCH] bcm43xx: Fix low-traffic netdev watchdog TX timeouts
This fixes a netdev watchdog timeout problem.
The software needs to call netif_tx_disable before running the
hardware calibration code. The problem condition can be shown by the
following timegraph.
|---5secs - ~10 jiffies time---|---|OOPS
^ ^
last real TX periodic work stops netif
At OOPS, the following happens:
The watchdog timer triggers, because the timeout of 5secs
is over. The watchdog first checks for stopped TX.
_Usually_ TX is only stopped from the TX handler to indicate
a full TX queue. But this is different. We need to stop TX here,
regardless of the TX queue state. So the watchdog recognizes
the stopped device and assumes it is stopped due to full
TX queues (Which is a _wrong_ assumption in this case). It then
tests how far the last TX has been in the past. If it's more than
5secs (which is the case for low or no traffic), it will fire
a TX timeout.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/es3210.c')
0 files changed, 0 insertions, 0 deletions