diff options
| author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2005-05-27 13:40:53 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-05-27 07:45:21 -0700 |
| commit | 88c1834633341bbb94e315433067496338bff4ad (patch) | |
| tree | 4ec40e39b38d768866fabc0dec7f9c4cfdc4b02d /drivers/usb/media/pwc/pwc-uncompress.c | |
| parent | 5d9e4ea55ae19f9083b9c2c97cc912b823ee7ab4 (diff) | |
[PATCH] remove non-cleanroom pwc driver compression
The original pwc author raised some questions about the reverse
engineering of the decompressor algorithms used in the pwc driver.
Having done some detailed investigation it appears those concerns that
clean room policy was not followed are reasonable. I've also had a
friendly discussion with Philips to ask their view on this.
This removes the problem items of code which reduces the pwc
functionality in the kernel a little but leaves all the framework for
setup that will be needed for decompressors in user space (where they
eventually belong). This change set is designed to be the minimal risk
change set given that 2.6.12 is hopefully close to hand, with a view to
merging the much updated pwc code in 2.6.13 series kernels.
Someone else can then redo the decompressors properly (clean room) in
user space.
Note that while its easy to say that it should have been caught earlier,
but the violation was really only obvious to someone who had access to
both the proprietary source and the 'GPL' source.
Diffstat (limited to 'drivers/usb/media/pwc/pwc-uncompress.c')
| -rw-r--r-- | drivers/usb/media/pwc/pwc-uncompress.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/media/pwc/pwc-uncompress.c b/drivers/usb/media/pwc/pwc-uncompress.c index c062e43b3ac..c596083f06b 100644 --- a/drivers/usb/media/pwc/pwc-uncompress.c +++ b/drivers/usb/media/pwc/pwc-uncompress.c @@ -122,6 +122,7 @@ int pwc_decompress(struct pwc_device *pdev) switch (pdev->type) { +#if 0 case 675: case 680: case 690: @@ -137,6 +138,7 @@ int pwc_decompress(struct pwc_device *pdev) case 645: case 646: /* TODO & FIXME */ +#endif return -ENXIO; /* No such device or address: missing decompressor */ break; } |