diff options
author | Hans Verkuil <hverkuil@xs4all.nl> | 2009-08-07 07:28:16 -0300 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-08-13 20:39:12 -0300 |
commit | 9bedc7f7fe803c17d26b5fcf5786b50a7cf40def (patch) | |
tree | fe8424c5bc15080e8069cd040c2e170205fe1dc4 /drivers/w1/w1_int.h | |
parent | 99362e1ece9f9651af1b849a01d91b9df1e0db2c (diff) |
V4L/DVB (12429): v4l2-ioctl: fix G_STD and G_PARM default handlers
The v4l core supplies default handlers for G_STD and G_PARM. However, both
default handlers are buggy.
This patch fixes the following:
1) If no g_std is supplied and current_norm == 0, then this driver does not
support TV video standards (e.g. a radio or webcam driver). Return
-EINVAL. This ensures that there is no bogus VIDIOC_G_STD support for
such drivers.
2) The default VIDIOC_G_PARM handler used current_norm instead of first
checking if the driver supported g_std and calling that to get the norm.
It also didn't check if current_norm was 0, since in that case the driver
does not support TV standards (or no standard was set at all) and the
default handler should return -EINVAL.
Note that I am very unhappy with these default handlers: I think they
basically behave like some very strange and unexpected side-effect.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/w1/w1_int.h')
0 files changed, 0 insertions, 0 deletions