diff options
author | Tejun Heo <tj@kernel.org> | 2009-11-11 15:35:18 +0900 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2009-11-13 00:55:35 +0900 |
commit | 833af8427be4b217b5bc522f61afdbd3f1d282c2 (patch) | |
tree | 7af86f8c599c4513f81c9b37ec34926cb4728316 /drivers/watchdog/sc520_wdt.c | |
parent | 4a6cc4bd32e580722882115d4c8b964d732c11e4 (diff) |
percpu: restructure pcpu_extend_area_map() to fix bugs and improve readability
pcpu_extend_area_map() had the following two bugs.
* It should return 1 if pcpu_lock was dropped and reacquired but it
returned 0. This could lead to oops if free_percpu() races with
area map extension.
* pcpu_mem_free() was called under pcpu_lock. pcpu_mem_free() might
end up calling vfree() which isn't IRQ safe. This could lead to
deadlock through lock order inversion via IRQ.
In addition, Linus pointed out that the temporary lock dropping and
subtle three-way return value of pcpu_extend_area_map() was very ugly
and suggested to split the function into two - pcpu_need_to_extend()
and pcpu_extend_area_map().
This patch restructures pcpu_extend_area_map() as suggested and fixes
the two bugs.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'drivers/watchdog/sc520_wdt.c')
0 files changed, 0 insertions, 0 deletions