aboutsummaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2009-01-05 14:18:40 -0800
committerGreg Kroah-Hartman <gregkh@suse.de>2009-01-06 13:52:11 -0800
commit18727963278a7199c75dba5ca3ad1e3455b1554a (patch)
treec9f9ae5e3977264306cd697a046742f5024b3de9 /drivers
parent91980990527258a075361490cecadbb7356fc0d2 (diff)
Staging: rt2860: disable root hack for reading files
We are now using credentials, so just blindly setting the fsuid and fsguid isn't acceptable. All this means is that the config file needs to be readable by the driver thread, not a big deal. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/staging/rt2860/rt_profile.c15
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/staging/rt2860/rt_profile.c b/drivers/staging/rt2860/rt_profile.c
index a38e557a9ec..cd7ffc8a6e8 100644
--- a/drivers/staging/rt2860/rt_profile.c
+++ b/drivers/staging/rt2860/rt_profile.c
@@ -925,9 +925,11 @@ NDIS_STATUS RTMPReadParametersHook(
// Save uid and gid used for filesystem access.
// Set user and group to 0 (root)
- orgfsuid = current->fsuid;
- orgfsgid = current->fsgid;
- current->fsuid=current->fsgid = 0;
+ orgfsuid = current_fsuid();
+ orgfsgid = current_fsgid();
+ /* Hm, can't really do this nicely anymore, so rely on these files
+ * being set to the proper permission to read them... */
+ /* current->cred->fsuid = current->cred->fsgid = 0; */
orgfs = get_fs();
set_fs(KERNEL_DS);
@@ -1551,8 +1553,11 @@ NDIS_STATUS RTMPReadParametersHook(
}
set_fs(orgfs);
- current->fsuid = orgfsuid;
- current->fsgid = orgfsgid;
+
+#if 0
+ current->cred->fsuid = orgfsuid;
+ current->cred->fsgid = orgfsgid;
+#endif
kfree(buffer);
kfree(tmpbuf);