diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-20 21:59:13 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-21 08:23:35 -0700 |
commit | cc216c5d429892872f70f76975e243aef7ad9db1 (patch) | |
tree | 6455048df83fb61c870367f7a88e701e44ebdd24 /net/ipv4/tcp_westwood.c | |
parent | 3925e6fc1f774048404fdd910b0345b06c699eb4 (diff) |
Fix RCU list iterator use of 'rcu_dereference()'
The RCU iterators used 'rcu_dereference()' on an already-fetched RCU
pointer value, which defeats the whole point of the exercise.
When we dereference a pointer protected by RCU, we need to make sure
that we only fetch the value _once_, because if the compiler ends up
re-loading it due to register pressure, the newly reloaded value could
be different from the previously fetched one, and you get inconsistent
results.
Cleaned-up, fixed, and the pointless list_for_each_safe_rcu #define
deleted by Paul Kenney.
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/ipv4/tcp_westwood.c')
0 files changed, 0 insertions, 0 deletions