diff options
| author | Chris Wright <chrisw@sous-sol.org> | 2007-03-09 16:19:17 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-03-09 16:19:17 -0800 |
| commit | d2b02ed9487ed25832d19534575052e43f8e0c4f (patch) | |
| tree | 292944e3306f4209dde7ffc18e36fc3d6e3fd8d7 /net/ipv6 | |
| parent | dfee0a725bb027b749ffdd318eb48b91d564b266 (diff) | |
[IPV6] fix ipv6_getsockopt_sticky copy_to_user leak
User supplied len < 0 can cause leak of kernel memory.
Use unsigned compare instead.
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
| -rw-r--r-- | net/ipv6/ipv6_sockglue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index b82333b9228..f5f9582a8d3 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c @@ -804,7 +804,7 @@ static int ipv6_getsockopt_sticky(struct sock *sk, struct ipv6_txoptions *opt, return 0; hdr = opt->hopopt; - len = min_t(int, len, ipv6_optlen(hdr)); + len = min_t(unsigned int, len, ipv6_optlen(hdr)); if (copy_to_user(optval, hdr, ipv6_optlen(hdr))) return -EFAULT; return len; |