diff options
author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2009-06-03 20:43:29 +0100 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2009-06-03 23:33:28 +0200 |
commit | 872c78202c58d26596e25743791ee81a7d24abad (patch) | |
tree | 5cca75beabf74f82a26b5649e2ae9aa23e4996fb /sound/core/misc.c | |
parent | 10a8ebbb08c4b08292598947bbe534e04d6ee705 (diff) |
ALSA: Fix double locking of card list in snd_card_register()
The introduction of snd_card_set_id() added a lock on the card list
to the old choose_default_id() function when using it to implement
the new API call. This lock is needed to allow us to walk the list
and check to see if our new name is a duplicate. Unfortunately this
causes a lockup when called from snd_card_register() (in cases
where no ID is supplied for the card) since the card list is already
locked there.
Fix this fairly hideously by factoring out the implementation and
using a flag to indicate if the lock should be held. A better fix
would probably be to refactor snd_card_register() to move the
_set_id() outside the locking region but I can't immediately see
anything I can convince myself is safe.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core/misc.c')
0 files changed, 0 insertions, 0 deletions