aboutsummaryrefslogtreecommitdiff
path: root/usr
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2008-01-28 20:52:12 -0800
committerDavid S. Miller <davem@davemloft.net>2008-01-31 19:27:08 -0800
commit8cf8e5a67fb07f583aac94482ba51a7930dab493 (patch)
tree0fa0b3c39ff3c1f3aca7b1013a1932f18ca2021d /usr
parent406a1d868001423c85a3165288e566e65f424fe6 (diff)
[INET_DIAG]: Fix inet_diag_lock_handler error path.
Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=9825 The inet_diag_lock_handler function uses ERR_PTR to encode errors but its callers were testing against NULL. This only happens when the only inet_diag modular user, DCCP, is not built into the kernel or available as a module. Also there was a problem with not dropping the mutex lock when a handler was not found, also fixed in this patch. This caused an OOPS and ss would then hang on subsequent calls, as &inet_diag_table_mutex was being left locked. Thanks to spike at ml.yaroslavl.ru for report it after trying 'ss -d' on a kernel that doesn't have DCCP available. This bug was introduced in cset d523a328fb0271e1a763e985a21f2488fd816e7e ("Fix inet_diag dead-lock regression"), after 2.6.24-rc3, so just 2.6.24 seems to be affected. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions