aboutsummaryrefslogtreecommitdiff
path: root/usr
diff options
context:
space:
mode:
authorHugh Dickins <hugh@veritas.com>2007-05-26 00:39:17 +0100
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-05-25 17:37:46 -0700
commitf4d43bd579f13219ffd3cae48432eab5bbac2d6f (patch)
treeb3376f267b2e519506633d0bdf73b8cb6d90a981 /usr
parent1ea0975875294964853209927feccdf6bc8cf5f9 (diff)
fix compat console unimap regression
Why is it that since the 2f1a2ccb9c0de632ab07193becf5f7121794f6ae console UTF-8 fixes went into 2.6.22-rc1, the PowerMac G5 shows only inverse video question marks for the text on tty2-6? whereas tty1 is fine, and so is x86. No fault of that patch: by removing the old fallback behaviour, it reveals that 32-bit setfont running on 64-bit kernels has only really worked on the current console, the rest getting faked by that inadequate fallback. Bring the compat do_unimap_ioctl into line with the main one: PIO_UNIMAP and GIO_UNIMAP apply to the specified tty, not redirected to fg_console. Use the same checks, and most particularly, remember to check access_ok: con_set_unimap and con_get_unimap are using __get_user and __put_user. And the compat vt_check should ask for the same capability as the main one, CAP_SYS_TTY_CONFIG rather than CAP_SYS_ADMIN. Added in vt_ioctl's vc_cons_allocated check for safety, though failure may well be impossible. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions