summaryrefslogtreecommitdiff
path: root/src/mesa/vbo
AgeCommit message (Collapse)Author
2010-02-09mesa: Enable true refcounting for NullBufferObj.Michal Krol
This object can be shared with another context, so we cannot just delete it when the owning context is being destroyed. Ensuring that buffer objects are properly refcounted guarantees NullBufferObj is destroyed when all references to it are removed.
2010-02-09mesa: Fix null buffer object reference counting.José Fonseca
Always use _mesa_reference_buffer_object, and never call ctx->Driver.DeleteBuffer() directly to prevent dangling pointers to the null buffer object. This fixes crash/assertions in sharedtex_mt and Autodesk Mudbox.
2010-02-03vbo: fix void * arithmetic warningKeith Whitwell
2010-02-03vbo: Fix up in-place splitting for non-contiguous/indexed primitives.Francisco Jerez
The in-place splitting code wasn't dealing with index buffers at all (and it was being called from vbo_split_prims for too big index buffers, causing some occasional corruption). Additionally, it wasn't taking into account primitives arrays with non-contiguous indices (e.g. given prim[0].start = 0 and prim[1].start = max_verts, it would happily call back the driver with (max_index - min_index) still greater than max_verts, causing infinite recursion). It still doesn't handle too large indexed vertex buffers: use vbo_split_copy for that.
2010-01-29vbo: fix missing state validation bugsBrian Paul
Commit 2708ddfb06a36d8568e2aa130bf1f7d551fcd309 caused a few regressions. We need to check/validate state after calling bind_arrays() because it might set the _NEW_ARRAYS flag if the varying VP inputs change. The symptom of this problem was some attribute arrays being ignored (or interpreted as constant-valued) in glDrawRangeElements or glMultiDrawElements. A follow-on patch will add some additional asserts to try to catch this kind of thing in the future. (cherry picked from commit 3cba779e16935f7c3a0bfd8af48bd5e015068e96)
2010-01-29mesa: Warn when indices are out of bounds, but do not skip the draw in debug ↵Brian Paul
builds. The driver (or preferably the hardware) should handle out of bounds indices. If there are problems then it's better to detect those in the debug builds. (cherry picked from commit e3257912e006120f6ab611e77005eed1a464030a)
2010-01-27mesa: fix int/uint comparison warningsBrian Paul
Reported by Karl Schultz.
2010-01-26vbo: if 'end' is out of bounds, clamp itBrian Paul
If we determine that the 'end' parameter to glDrawElements() is out of bounds, clamp it to the max legal index value.
2010-01-26vbo: clamp DrawElements start/end to max possible valuesBrian Paul
Some apps are sloppy with their start/end values. Clamp them to max possible values to prevent problems later.
2010-01-12vbo: Remove unnecessary headers from vbo_exec.c.Vinson Lee
2010-01-12vbo: Remove unnecessary header from vbo_exec_array.c.Vinson Lee
2010-01-12vbo: Remove unnecessary header from vbo_exec_draw.c.Vinson Lee
2010-01-12vbo: Remove unnecessary headers from vbo_save.c.Vinson Lee
2010-01-11vbo: Remove unnecessary header from vbo_save_loopback.c.Vinson Lee
2010-01-11vbo: Remove unnecessary header from vbo_split_copy.c.Vinson Lee
2009-12-11Merge branch 'mesa_7_6_branch' into mesa_7_7_branchBrian Paul
2009-12-08vbo: fix array index out of bounds error, and fix evaluator prioritiesBrian Paul
Fixes bug 25525. Plus, the GL_NV_vertex_program evaluators alias and override the convential evaluator maps, so set their state after the conventional maps.
2009-12-01vbo: make flush recursion check code per-contextBrian Paul
This fixes invalid failed assertions when running multi-threaded apps.
2009-11-19vbo: added recursion check in vbo_exec_FlushVertices()Brian Paul
2009-11-17mesa: fix assorted compiler warningsBrian Paul
2009-11-04Merge branch 'mesa_7_6_branch'Brian Paul
Conflicts: src/mesa/drivers/windows/gdi/mesa.def
2009-11-04vbo: fix out-of-bounds array accessBrian Paul
The exec->vtx.inputs[] array was being written past its end. This was clobbering the following vbo_exec_context::eval state. Probably not noticed since evaluators and immediate mode rendering don't happen at the same time. Fixed the loop in vbo_exec_vtx_init(). Changed the size of the vbo_exec_context::vtx.arrays[] array. Added a bunch of debug-build assertions. Issue found by Vinson Lee.
2009-10-22mesa: fix up vbo commentsBrian Paul
2009-10-14vbo: clean-ups, reformattingBrian Paul
2009-10-14mesa: added MESA_VERBOSE option 'draw' to debug glDrawArrays/Elements, etc.Brian Paul
2009-10-07mesa: rename display list functionsBrian Paul
_mesa_alloc_instruction() sounded like it was related to vertex/fragment program instructions, but it wasn't.
2009-09-30mesa/main: New feature FEATURE_beginend.Chia-I Wu
This feature corresponds to the Begin/End paradigm. Disabling this feature also eliminates the use of GLvertexformat completely.
2009-09-30mesa/main: Make FEATURE_dlist follow feature conventions.Chia-I Wu
As shown in mfeatures.h, this allows users of dlist.h to work without knowing if the feature is available.
2009-09-30mesa/main: Make FEATURE_evaluators follow feature conventions.Chia-I Wu
As shown in mfeatures.h, this allows users of eval.h to work without knowing if the feature is available.
2009-09-30mesa/main: New feature FEATURE_arrayelt.Chia-I Wu
This allows the removal of AEcontext.
2009-09-24Merge branch 'mesa_7_6_branch'Brian Paul
Conflicts: src/mesa/vbo/vbo_exec_array.c
2009-09-24vbo: limit number of warnings to 10Brian Paul
Otherwise some apps will emit tons of warnings.
2009-09-21vbo: added comment about max array indexBrian Paul
2009-09-21vbo: restore some lost warning outputBrian Paul
2009-09-21vbo: disable the GL_ARB_draw_elements_base_vertex rebase pathBrian Paul
This was introduced with commit 92d7ed8a20d4a018ce5324e6537ae7b478b9e5bf. It causes rendering of stray polygons (with sw rendering at least) when running the OGL Distilled / Picking demo (click on an object). This needs additional debugging to fix/restore. Found one suspect thing: in _tnl_draw_prims() there's some mixed signed/ unsigned arithmetic/comparing at line 422 that may be incorrect.
2009-09-21mesa: refine the error checking vbo_exec_DrawRangeElements()Brian Paul
If the 'end' index is out of bounds issue a warning as before. But instead of just no-op'ing the draw call, examine the actual array indices to see if they're OK. If the max array index is out of bounds, issue another warning and no-op the draw call. Otherwise, draw normally. This is a debug build-only feature since it could impact performance. This "fixes" the missing torus in the OGL Distilled / Picking demo.
2009-09-21mesa: refine the error checking vbo_exec_DrawRangeElements()Brian Paul
If the 'end' index is out of bounds issue a warning as before. But instead of just no-op'ing the draw call, examine the actual array indices to see if they're OK. If the max array index is out of bounds, issue another warning and no-op the draw call. Otherwise, draw normally. This is a debug build-only feature since it could impact performance. This "fixes" the missing torus in the OGL Distilled / Picking demo.
2009-09-08mesa: Add support for ARB_draw_elements_base_vertex.Eric Anholt
2009-09-01mesa: Make MultiDrawElements submit multiple primitives at once.Eric Anholt
Previously, MultiDrawElements just called DrawElements a bunch of times. By sending several primitives down the pipeline at once, we avoid a bunch of validation. On my GL demo, this improves fps by 2.5% (+/- .41%) and reduces CPU usage by 70.5% (+/- 2.9%) (n=3). Reviewed by: Ian Romanick <ian.d.romanick@intel.com>
2009-08-28vbo: Fix array pointer calculation for MapBufferRange-mapped vertex data.Eric Anholt
We would end up with the offset from the start of the mapping rather than the offset from the start of the buffer.
2009-08-26Merge branch 'mesa_7_5_branch'Brian Paul
2009-08-24vbo: fix divide by zero exceptionBrian Paul
Fixes bug 23489.
2009-08-24vbo: fix divide by zero exceptionBrian Paul
Fixes bug 23489.
2009-08-14vbo: call _mesa_valid_to_render()Brian Paul
2009-08-14vbo: call _mesa_valid_to_render()Brian Paul
2009-08-12vbo: use _mesa_is_bufferobj()Brian Paul
2009-08-12vbo: fix incorrect pointerBrian Paul
2009-08-12vbo: Avoid extra validation of DrawElements.Eric Anholt
This saves mapping the index buffer to get a bounds on the indices that drivers just drop on the floor in the VBO case (cache win), saves a bonus walk of the indices in the CheckArrayBounds case, and other miscellaneous validation. On intel it's a particularly a large win (50-100% in my app) because even though we let the indices stay in both CPU and GPU caches, we still end up waiting for the GPU to be done with the buffer before reading from it. Drivers that want the min/max_index fields must now check index_bounds_valid and use vbo_get_minmax_index before using them.
2009-07-30vbo: Fix build on windows.Michal Krol
2009-07-13Merge branch 'mesa_7_5_branch'Brian Paul