diff options
| author | Thomas White <taw@physics.org> | 2021-05-17 11:37:21 +0200 |
|---|---|---|
| committer | Thomas White <taw@physics.org> | 2021-05-17 11:52:42 +0200 |
| commit | 6026a3eaf235b59671ac2437e0c9a4fa8878b856 (patch) | |
| tree | e68feddd893f3e8e67bc297fdc9d9ce2fbb7be4e /src | |
| parent | affdfe20be27586a65b4db483f04481008ae63fe (diff) | |
Resolve FIXMEs and TODOs
Prompted by the article linked below, for each FIXME/TODO I've either
referenced an issue in the tracker, or removed it if it's not worth
fixing.
https://schleiss.io/plotting-source-code-todos-for-open-source-projects
Diffstat (limited to 'src')
| -rw-r--r-- | src/crystfel_gui.c | 2 | ||||
| -rw-r--r-- | src/crystfelimageview.c | 2 | ||||
| -rw-r--r-- | src/geoptimiser.c | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/src/crystfel_gui.c b/src/crystfel_gui.c index 28661064..700cc4f1 100644 --- a/src/crystfel_gui.c +++ b/src/crystfel_gui.c @@ -640,7 +640,7 @@ static void add_button(GtkWidget *vbox, const char *label, const char *imagen, static void add_task_buttons(GtkWidget *vbox, struct crystfelproject *proj) { - /* FIXME: All these icons are placeholders */ + /* FIXME: All these icons are placeholders (GitLab #9) */ add_button(vbox, "Load data", "folder-pictures", G_CALLBACK(import_sig), proj); add_button(vbox, "Peak detection", "edit-find", diff --git a/src/crystfelimageview.c b/src/crystfelimageview.c index 8302ae44..12ef1dee 100644 --- a/src/crystfelimageview.c +++ b/src/crystfelimageview.c @@ -239,7 +239,7 @@ static void draw_pixel_values(cairo_t *cr, PangoFontDescription *fontdesc; double w, h; - /* FIXME: This is wrong for slanty pixels */ + /* FIXME: This is wrong for slanty pixels (GitLab #17) */ min_fs = clamp(imin_fs, 0, p.w-1); min_ss = clamp(imin_ss, 0, p.h-1); max_fs = clamp(imax_fs, 0, p.w-1); diff --git a/src/geoptimiser.c b/src/geoptimiser.c index 24a159de..f28e9551 100644 --- a/src/geoptimiser.c +++ b/src/geoptimiser.c @@ -1074,7 +1074,7 @@ static DataTemplate *correct_rotation_and_stretch(struct rg_collection *connecte struct geoptimiser_params *gparams) { #if 0 - /* FIXME ! */ + /* FIXME (GitLab #29) */ int di, ip; STATUS("Applying rotation and stretch corrections.\n"); @@ -1392,7 +1392,7 @@ static void correct_shift(struct rg_collection *connected, double clen_to_use) { #if 0 - /* FIXME ! */ + /* FIXME (GitLab #29) */ int di; int ip; @@ -1585,7 +1585,7 @@ static double compute_rotation_and_stretch(struct rg_collection *connected, num_pix_first_p = first_p->w * first_p->h; - /* FIXME: minrad here is not universal */ + /* FIXME: minrad here is not universal (GitLab #29) */ min_dist = dist_coeff_for_rot_str * sqrt(num_pix_first_p * connected->rigid_groups[di]->n_panels); |