Age | Commit message (Collapse) | Author |
|
Similar code was stripped out 3.5 years ago by
4f4e5d05269eee6b192c271f2f9730a1ad3a4fbd. However, it seems there are
still systems where it improves performance a lot.
|
|
Use of these programs has been following this pattern for several years:
1. Neglect
2. Once yearly attempt by someone to use either tool
3. Discovery that it's totally broken
4. Bug report and fast bug fix
5. Go to 1.
For more discussion, see the issue referenced below.
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/81
|
|
It's already far behind parity with Meson, and getting worse.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Corrected version of commit.
|
|
This reverts commit 044560941c0aa28e1e809f148ce553e985b4e868.
Accidentally committed stuff that should not be there yet.
|
|
|
|
These are now installed (no more copy/chmod needed), and accessible from
the GUI.
|
|
|
|
Analogous fixes to those done for partial_sim in 0effb5f83daf0317aa97a1cd10e7708551a25201.
|
|
It's been broken for a long time. Now, at least it does what the
documentation says it does.
Fixes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/78
|
|
The tutorial won't work, if followed exactly, unless the mask is in the
working directory. Saving it next to the geometry file, but in a
different folder, won't work.
Fixes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/77
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Same deal as 6ead0af32.
|
|
|
|
This has a cleaner background, and the window icon has been fixed (see
ad8494c441231).
|
|
This commit strips out all references to the Slurm API, instead making
subprocess calls to sbatch and scontrol.
Attempting to use the Slurm API seems to have been a mis-step. First,
it seems that nowhere has the Slurm headers pre-installed. Literally
none of the facilities where there are known deployments of CrystFEL
have them. And in a significant fraction of cases, getting them
installed is difficult, slow or impossible.
In addition, the API doesn't seem to work in all cases, so we already
shell out to 'scancel' to abort jobs - see d76fc3495.
There are some tricky implications for submitting Slurm jobs from a
container via the API. The Slurm REST API offers a solution, but is
very new and not widely available. Calls to the Slurm executables are
much easier to 'tunnel' out of a container.
This isn't a great solution. It's a net increase of only about 40 lines
of source code, but it incurs some unpleasant string handling and will
probably be less reliable overall. It completely relies on Slurm's not
being internationalised. If Slurm's messages start getting translated,
we will be in trouble.
|
|
|
|
The csplit format is ambiguous when the filenames contain spaces. To
make things a bit clearer, the file now requires the fields to be
separated by exactly one space rather than any number of tabs/spaces.
Fixes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/55
|
|
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/27
|
|
This got missed out by accident in the conversion to DataTemplate, but
absolutely no-one noticed. In the meantime, my views on how the
geometry files should work have changed somewhat. I don't want to
maintain the extra complexity here when it isn't even clear that it will
eliminate the need to re-refine geometry for each camera length.
This commit just takes the rail direction stuff out of the documentation
and the geometry file parser.
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/50
|
|
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/52
|
|
|
|
|
|
|
|
|
|
|