aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Paris <eparis@redhat.com>2009-11-20 11:00:12 -0500
committerJames Morris <jmorris@namei.org>2009-11-23 09:00:44 +1100
commit85c3b529f8ad4d65ba86b982ef050212ae7dd976 (patch)
treebecd5d4d607faf5de3bf5d8470cacf715aef8f7a
parent821d35a56044e522e811f6a1e8632cc230360280 (diff)
SELinux: header generation may hit infinite loop
If a permission name is long enough the selinux class definition generation tool will go into a infinite loop. This is because it's macro max() is fooled into thinking it is dealing with unsigned numbers. This patch makes sure the macro always uses signed number so 1 > -1. Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: James Morris <jmorris@namei.org>
-rw-r--r--scripts/selinux/genheaders/genheaders.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c
index 771b86f4619..24626968055 100644
--- a/scripts/selinux/genheaders/genheaders.c
+++ b/scripts/selinux/genheaders/genheaders.c
@@ -13,7 +13,7 @@ struct security_class_mapping {
#include "classmap.h"
#include "initial_sid_to_string.h"
-#define max(x, y) ((x > y) ? x : y)
+#define max(x, y) (((int)(x) > (int)(y)) ? x : y)
const char *progname;