diff options
| author | David S. Miller <davem@davemloft.net> | 2009-02-08 22:32:31 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-08 22:32:31 -0800 |
| commit | aeb398768345c74a9e4c01aa3ebf839e858312ec (patch) | |
| tree | c7755f40260ccf89e8f3b765a9b44dcbebcae896 /arch/sparc/lib/NG2copy_from_user.S | |
| parent | 40bdac7dbc161639a498697f34fbd1ee800e51f4 (diff) | |
sparc64: Fix probe_kernel_{read,write}().
This is based upon a report from Chris Torek and his initial patch.
From Chris's report:
--------------------
This came up in testing kgdb, using the built-in tests -- turn
on CONFIG_KGDB_TESTS, then
echo V1 > /sys/module/kgdbts/parameters/kgdbts
-- but it would affect using kgdb if you were debugging and looking
at bad pointers.
--------------------
When we get a copy_{from,to}_user() request and the %asi is set to
something other than ASI_AIUS (which is userspace) then we branch off
to a routine called memcpy_user_stub(). It just does a straight
memcpy since we are copying from kernel to kernel in this case.
The logic was that since source and destination are both kernel
pointers we don't need to have exception checks.
But for what probe_kernel_{read,write}() is trying to do, we have to
have the checks, otherwise things like kgdb bad kernel pointer
accesses don't do the right thing.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/lib/NG2copy_from_user.S')
| -rw-r--r-- | arch/sparc/lib/NG2copy_from_user.S | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/sparc/lib/NG2copy_from_user.S b/arch/sparc/lib/NG2copy_from_user.S index 01ac546a86f..119ccb9a54f 100644 --- a/arch/sparc/lib/NG2copy_from_user.S +++ b/arch/sparc/lib/NG2copy_from_user.S @@ -28,7 +28,7 @@ #define PREAMBLE \ rd %asi, %g1; \ cmp %g1, ASI_AIUS; \ - bne,pn %icc, memcpy_user_stub; \ + bne,pn %icc, ___copy_in_user; \ nop #endif |