diff options
author | Michael Chan <mchan@broadcom.com> | 2007-07-11 19:47:19 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2007-07-11 19:47:19 -0700 |
commit | 469665459d26da8d0b46c70d070da1e192e48e46 (patch) | |
tree | e64f86c93ad9350c7e042672de12fda26592249a /drivers/net/natsemi.c | |
parent | db3d99c090e0cdb34b1274767e062bfddbb384bc (diff) |
[TG3]: Fix irq_sync race condition.
Gagan Arneja <gaagaan@gmail.com> pointed out that tg3_reset_task()
could potentially race with another thread calling tg3_full_lock()
such as the ethtool_set_xxx() functions. This may trigger the
BUG_ON() in tg3_irq_quiesce() or cause the irq_sync flag to be out-
of-sync.
I think the easiest way to fix this is to get the tp->lock first
before setting the irq_sync flag. This is safe to do because the
tp->lock is never grabbed by the irq handler. This change will
guarantee that the irq_sync flag updates will be serialized. We also
have to change one spot to call tg3_netif_start() (which clears the
irq_sync flag) before releasing the tp->lock.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/natsemi.c')
0 files changed, 0 insertions, 0 deletions