aboutsummaryrefslogtreecommitdiff
path: root/drivers/net/sfc/ethtool.c
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2008-09-01 12:48:46 +0100
committerJeff Garzik <jgarzik@redhat.com>2008-09-03 09:53:48 -0400
commitbc3c90a2b70652b87cde8de65275d6f41d0f24c3 (patch)
tree3d9a7eebad85bc86f5a3fbd4fdf4cc2b7be950a4 /drivers/net/sfc/ethtool.c
parentc1e5fcc980b7b2185b29e4f9f0d8266806ada9eb (diff)
sfc: Remove some unreachable error paths
Some functions return an error code which is always 0. Change their return types to void and simplify their callers accordingly. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/sfc/ethtool.c')
-rw-r--r--drivers/net/sfc/ethtool.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/sfc/ethtool.c b/drivers/net/sfc/ethtool.c
index 906d18a6526..79894160a9a 100644
--- a/drivers/net/sfc/ethtool.c
+++ b/drivers/net/sfc/ethtool.c
@@ -503,10 +503,10 @@ static void efx_ethtool_self_test(struct net_device *net_dev,
if (offline) {
/* Stop the kernel from sending packets during the test. */
efx_stop_queue(efx);
- rc = efx_flush_queues(efx);
- if (!rc)
- rc = efx_offline_test(efx, &efx_tests,
- efx->loopback_modes);
+ efx_flush_queues(efx);
+
+ rc = efx_offline_test(efx, &efx_tests,
+ efx->loopback_modes);
efx_wake_queue(efx);
}