aboutsummaryrefslogtreecommitdiff
path: root/drivers/scsi/fnic/fnic_res.c
diff options
context:
space:
mode:
authorJoe Eykholt <jeykholt@cisco.com>2009-11-03 11:49:16 -0800
committerJames Bottomley <James.Bottomley@suse.de>2009-12-04 12:01:18 -0600
commit386309ce927a308d7742a6fb24a536d3383fbd49 (patch)
tree4e8ddbb895e5bd837020896a1c2505ea8bc3159b /drivers/scsi/fnic/fnic_res.c
parente6d8a1b0b53a156979120dd0593c1867b8ea89d3 (diff)
[SCSI] libfcoe: fcoe: simplify receive FLOGI response
There was a locking problem where the fip->lock was held during the call to update_mac(). The rtnl_lock() must be taken before the fip->lock, not the other way around. This fixes that. Now that fcoe_ctlr_recv_flog() is called only from the response handler to a FLOGI request, some checking can be eliminated. Instead of calling update_mac(), just fill in the granted_mac address for the passed-in frame (skb). Eliminate the passed-in source MAC address since it is also in the skb. Also, in fcoe, call fcoe_set_src_mac() directly instead of going thru the fip function pointer. This will generate less code. Then, since fip isn't needed for LOGO response, use lport as the arg. Signed-off-by: Joe Eykholt <jeykholt@cisco.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/fnic/fnic_res.c')
0 files changed, 0 insertions, 0 deletions