diff options
author | Dan Carpenter <error27@gmail.com> | 2010-04-27 14:11:05 -0700 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2010-04-28 18:42:52 +1000 |
commit | a1c4560d4d8909cc4feb6f9e875d0b92083e05cf (patch) | |
tree | 5fad4d68b80048f95068637c17888d700a47e09e /drivers/video | |
parent | 0031c41be5c529f8329e327b63cde92ba1284842 (diff) |
drivers/gpu/drm/drm_sysfs.c: sysfs files error handling
In the original code we used "j" as an iterator but we used "i" as an
index.
- for (j = 0; j < i; j++)
- device_remove_file(&connector->kdev,
- &connector_attrs[i]);
Smatch complained about that because "i" was potentially passed the end of
the array. Which makes sense if we should be using "j" there.
I also thought that we should remove the files for &connector_attrs_opt1
but to do that I had to add separate iterators for &connector_attrs and
&connector_attrs_opt1.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/video')
0 files changed, 0 insertions, 0 deletions