aboutsummaryrefslogtreecommitdiff
path: root/firmware/keyspan
diff options
context:
space:
mode:
authorDavid Brownell <david-b@pacbell.net>2008-07-23 21:30:33 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2008-07-24 10:47:33 -0700
commit5ad31a575157147b43fa84ef1e21471661653878 (patch)
treec4a42d45957362aa8391938ae3e11496321c19d8 /firmware/keyspan
parent53f1b1433da7eac2607a4a0898a221a4485fd732 (diff)
rtc: remove BKL for ioctl()
Remove implicit use of BKL in ioctl() from the RTC framework. Instead, the rtc->ops_lock is used. That's the same lock that already protects the RTC operations when they're issued through the exported rtc_*() calls in drivers/rtc/interface.c ... making this a bugfix, not just a cleanup, since both ioctl calls and set_alarm() need to update IRQ enable flags and that implies a common lock (which RTC drivers as a rule do not provide on their own). A new comment at the declaration of "struct rtc_class_ops" summarizes current locking rules. It's not clear to me that the exceptions listed there should exist ... if not, those are pre-existing problems which can be fixed in a patch that doesn't relate to BKL removal. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Jonathan Corbet <corbet@lwn.net> Acked-by: Alessandro Zummo <a.zummo@towertech.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'firmware/keyspan')
0 files changed, 0 insertions, 0 deletions