diff options
author | Darrick J. Wong <djwong@us.ibm.com> | 2007-05-08 00:25:47 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-08 11:15:02 -0700 |
commit | 59cd0cbc75367b82f704f63b104117462275060d (patch) | |
tree | 695c4f7af4cf840a7e22e7767e1b5705e0b6d8d1 /fs/char_dev.c | |
parent | 7695650a924a6859910c8c19dfa43b4d08224d66 (diff) |
Fix race between proc_readdir and remove_proc_entry
Fix the following race:
proc_readdir remove_proc_entry
============ =================
spin_lock(&proc_subdir_lock);
[choose PDE to start filldir from]
spin_unlock(&proc_subdir_lock);
spin_lock(&proc_subdir_lock);
[find PDE]
[free PDE, refcount is 0]
spin_unlock(&proc_subdir_lock);
/* boom */
if (filldir(dirent, de->name, ...
[de_put on error path --adobriyan]
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/char_dev.c')
0 files changed, 0 insertions, 0 deletions