diff options
author | Pavel Emelyanov <xemul@openvz.org> | 2008-04-14 00:44:52 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-04-14 00:44:52 -0700 |
commit | 4dee959723e2bf3a0f9343a46841cd2f0029d424 (patch) | |
tree | a7ae0cedd9dccee806b6a7ba6a7e017a271850ca /net/core/dev.c | |
parent | 9625ed72e8bd619c3984f3024bd37143b7f0c7b0 (diff) |
[NETFILTER]: ipt_CLUSTERIP: fix race between clusterip_config_find_get and _entry_put
Consider we are putting a clusterip_config entry with the "entries"
count == 1, and on the other CPU there's a clusterip_config_find_get
in progress:
CPU1: CPU2:
clusterip_config_entry_put: clusterip_config_find_get:
if (atomic_dec_and_test(&c->entries)) {
/* true */
read_lock_bh(&clusterip_lock);
c = __clusterip_config_find(clusterip);
/* found - it's still in list */
...
atomic_inc(&c->entries);
read_unlock_bh(&clusterip_lock);
write_lock_bh(&clusterip_lock);
list_del(&c->list);
write_unlock_bh(&clusterip_lock);
...
dev_put(c->dev);
Oops! We have an entry returned by the clusterip_config_find_get,
which is a) not in list b) has a stale dev pointer.
The problems will happen when the CPU2 will release the entry - it
will remove it from the list for the 2nd time, thus spoiling it, and
will put a stale dev pointer.
The fix is to make atomic_dec_and_test under the clusterip_lock.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net/core/dev.c')
0 files changed, 0 insertions, 0 deletions