aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/design.txt
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-12-13 17:07:45 +0100
committerJohn W. Linville <linville@tuxdriver.com>2009-12-21 11:32:02 -0500
commit855da5e07ef4dba5f23d8f6f31004116ba16c52a (patch)
treee9c66e33825d930a488a642dbd29c1c3ab44a738 /tools/perf/design.txt
parent4d91f9f3730d6d82a3ba67cae215a1823ba6a191 (diff)
drivers/net/wireless: Correct code taking the size of a pointer
sizeof(iv16) and sizeof(iv32) are the sizes of pointers. Change them to the size of the copied data. Furthermore, iveiv_entry is a local structure that has just been initialized and is not visible outside this function. Thus, there would seem to be no point to copy data into it. The order of the arguments is thus changed to copy the data into the parameters, which are provided as pointers, suggesting in this case that they should be used to return values. A simplified version of the semantic patch that finds the first problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression *x; expression f; type T; @@ *f(...,(T)x,...) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Gertjan van Wingerde <gwingerde@gmail.com> Acked-by: Ivo van Doorn <IvDoorn@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'tools/perf/design.txt')
0 files changed, 0 insertions, 0 deletions