diff options
| author | Brian Paul <brianp@vmware.com> | 2009-09-21 16:54:35 -0600 |
|---|---|---|
| committer | Brian Paul <brianp@vmware.com> | 2009-09-21 16:54:35 -0600 |
| commit | 94a020cfe6cb1da04695897eed38b530af31f524 (patch) | |
| tree | 9c741f0e0c75e1924800cc14c93967a830b14ccc | |
| parent | 9a3333f43600ed4b9a17e49f79004f0c8d289378 (diff) | |
vbo: added comment about max array index
| -rw-r--r-- | src/mesa/vbo/vbo_exec_array.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index ee37eeb937..668dc6eb24 100644 --- a/src/mesa/vbo/vbo_exec_array.c +++ b/src/mesa/vbo/vbo_exec_array.c @@ -678,6 +678,12 @@ vbo_exec_DrawRangeElementsBaseVertex(GLenum mode, type, indices, basevertex )) return; + /* NOTE: It's important that 'end' is a reasonable value. + * in _tnl_draw_prims(), we use end to determine how many vertices + * to transform. If it's too large, we can unnecessarily split prims + * or we can read/write out of memory in several different places! + */ + if (end >= ctx->Array.ArrayObj->_MaxElement) { /* the max element is out of bounds of one or more enabled arrays */ _mesa_warning(ctx, "glDraw[Range]Elements(start %u, end %u, count %d, " |