diff options
| author | Thomas White <taw@physics.org> | 2021-05-17 11:37:21 +0200 |
|---|---|---|
| committer | Thomas White <taw@physics.org> | 2021-05-17 11:52:42 +0200 |
| commit | 6026a3eaf235b59671ac2437e0c9a4fa8878b856 (patch) | |
| tree | e68feddd893f3e8e67bc297fdc9d9ce2fbb7be4e /libcrystfel/src/indexers | |
| parent | affdfe20be27586a65b4db483f04481008ae63fe (diff) | |
Resolve FIXMEs and TODOs
Prompted by the article linked below, for each FIXME/TODO I've either
referenced an issue in the tracker, or removed it if it's not worth
fixing.
https://schleiss.io/plotting-source-code-todos-for-open-source-projects
Diffstat (limited to 'libcrystfel/src/indexers')
| -rw-r--r-- | libcrystfel/src/indexers/mosflm.c | 28 | ||||
| -rw-r--r-- | libcrystfel/src/indexers/taketwo.c | 2 |
2 files changed, 1 insertions, 29 deletions
diff --git a/libcrystfel/src/indexers/mosflm.c b/libcrystfel/src/indexers/mosflm.c index 02532103..c56f3ae6 100644 --- a/libcrystfel/src/indexers/mosflm.c +++ b/libcrystfel/src/indexers/mosflm.c @@ -29,31 +29,6 @@ * */ -/* TODO: - * - * Properly read the newmat file (don't use fscanf-- spaces between numers - * are not guaranteed) - * - * "Success" is indicated by existence of NEWMAT file written by mosflm. - * Better to interact with mosflm directly in order to somehow verify success. - * - * Investigate how these keywords affect mosflms behavior: - * - * MOSAICITY - * DISPERSION - * DIVERGENCE - * POLARISATION - * POSTREF BEAM - * POSTREF USEBEAM OFF - * PREREFINE ON - * EXTRA ON - * POSTREF ON - * - * These did not seem to affect the results by my (Rick's) experience, probably - * because they are only used conjunction with image intensity data, but it's - * worth another look at the documentation. - */ - #include <libcrystfel-config.h> #include <stdlib.h> @@ -575,8 +550,7 @@ static void mosflm_send_next(struct image *image, struct mosflm_data *mosflm) &a, &b, &c, &alpha, &beta, &gamma); cen = cell_get_centering(mosflm->mp->template); /* Old MOSFLM simply ignores CELL and CENTERING subkeywords. - * So this doesn't do any harm. - * TODO: but still better to show WARNING if MOSFLM is old. */ + * So this doesn't do any harm. */ snprintf(tmp, 255, "AUTOINDEX DPS FILE %s IMAGE 1 " "MAXCELL 1000 REFINE " "CELL %.1f %.1f %.1f %.1f %.1f %.1f " diff --git a/libcrystfel/src/indexers/taketwo.c b/libcrystfel/src/indexers/taketwo.c index 4b481e93..8ce33083 100644 --- a/libcrystfel/src/indexers/taketwo.c +++ b/libcrystfel/src/indexers/taketwo.c @@ -248,8 +248,6 @@ struct TakeTwoCell /* Final required step size for refinement of solutions */ #define ANGLE_CONVERGE_SIZE (deg2rad(0.01)) -/* TODO: Multiple lattices */ - /* ------------------------------------------------------------------------ * apologetic function |