| Age | Commit message (Collapse) | Author |
|---|
|
While compiling CrystFEL using musl, this error message popped up:
In file included from ../libcrystfel/src/indexers/pinkindexer.c:36:
x86_64-unknown-linux-musl/sys-include/sys/errno.h:1:2:
warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> [-Wcpp]
1 | #warning redirecting incorrect #include <sys/errno.h> to <errno.h>
| ^~~~~~~
So I removed sys/errno.h completely (since I couldn't figure out where
it was used in the file anyways), and the result still compiled.
|
|
|
|
|
|
Making them opaque seemed like a nice idea, because all the indexers
could take care of their own command-line arguments. However, it
doesn't work at all when indexing is run via the API.
|
|
This removes the big potential for confusion, which has happened several
times (see e.g. 095cbebaf6). It also fixes in-tree builds with CMake
(but seriously, always use out-of-tree builds).
Fixes #2.
|
|
Unfortunately, PinkIndexer needs the real camera length for its centre
refinement. Giving a fake value and scaling the resulting shift does
not work - the indexing rate drops with even a small error.
Ideally, this would work in the same way as --wavelength-estimate, by
using a static value from the geometry file if it's given. However,
this is rather complicated to implement because of the way all the units
stuff is implemented. Therefore, this is left as an improvement for the
future.
|
|
|
|
The FIXMEs have both already been fixed.
|
|
This is a more general replacement for --pinkIndexer-thread-count.
|
|
There doesn't seem to be any point in allocating them earlier, except to
make space for some nice bugs.
|
|
|
|
This will return later in a more centralised form, if we decide to work
further on wide bandwidth.
|
|
... and calculate the real value afterwards, checking that the detector
is really flat enough for it to work.
|
|
These conflict badly with CrystFEL's own checks, creating a horrible
user and developer experience.
Later, if we want to handle wide bandwidth beams, we will improve the
central CrystFEL checks to support it.
|
|
This allows the refined detector position to be used in a lot of places.
|
|
This brings it up to date after e7cf3911104f.
|
|
There is absolutely nothing useful that an indexing algorithm can do
with the opaque DataTemplate object.
|
|
This is a more sensible non-indexer-specific and non-Xray-specific
replacement for --pinkIndexer-override-photon-energy
|
|
This allows the indexing method private options structures to be set up
easily.
|
|
|
|
Overall detector offsets can now be done via the geometry file, and this
is labelled as a hack. It doesn't actually do very much anyway, because the
"updated" detector is thrown away for the next pattern. The updated detector
is used only for subsequent indexing attempts on the same pattern.
|
|
|
