Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
|
|
'changed' is initialised to zero, so there's no way this check can fail.
|
|
|
|
|
|
|
|
|
|
Making them opaque seemed like a nice idea, because all the indexers
could take care of their own command-line arguments. However, it
doesn't work at all when indexing is run via the API.
|
|
Prompted by the article linked below, for each FIXME/TODO I've either
referenced an issue in the tracker, or removed it if it's not worth
fixing.
https://schleiss.io/plotting-source-code-todos-for-open-source-projects
|
|
This removes some old stub code. There doesn't seem to be a big need
for doing what the FIXME suggests.
|
|
This removes the big potential for confusion, which has happened several
times (see e.g. 095cbebaf6). It also fixes in-tree builds with CMake
(but seriously, always use out-of-tree builds).
Fixes #2.
|
|
|
|
This isn't necessary after all, for the same reason that im-sandbox
doesn't need escaping: it can count off the fields where spaces aren't
allowed, and anything left is the filename. I was over-thinking things.
|
|
|
|
|
|
Unfortunately, PinkIndexer needs the real camera length for its centre
refinement. Giving a fake value and scaling the resulting shift does
not work - the indexing rate drops with even a small error.
Ideally, this would work in the same way as --wavelength-estimate, by
using a static value from the geometry file if it's given. However,
this is rather complicated to implement because of the way all the units
stuff is implemented. Therefore, this is left as an improvement for the
future.
|
|
|
|
The FIXMEs have both already been fixed.
|
|
|
|
There is presumably an MPSD that also needs to be added.
|
|
|
|
Significant change: the solution file must now come with the lattice
type, centering and (if applicable) unique axis information at the end
of each line, e.g. 'cI' (cubic I), 'mAb' (monoclinic A, unique axis b).
|
|
This give FromFile its own private command-lien option processing, like
the other indexers. It removes the ability to auto-generate the
solution filename, but I don't think there's a way to do that without
breaking abstractions.
|
|
|
|
|
|
|
|
It's only used for some error messages, and it doesn't compile anyway.
|
|
Everything should use the per-crystal detector shift now.
|
|
|
|
|
|
Also adds to meson.build
|
|
This is a more general replacement for --pinkIndexer-thread-count.
|
|
There doesn't seem to be any point in allocating them earlier, except to
make space for some nice bugs.
|
|
|
|
This will return later in a more centralised form, if we decide to work
further on wide bandwidth.
|
|
... and calculate the real value afterwards, checking that the detector
is really flat enough for it to work.
|
|
These conflict badly with CrystFEL's own checks, creating a horrible
user and developer experience.
Later, if we want to handle wide bandwidth beams, we will improve the
central CrystFEL checks to support it.
|
|
This allows the refined detector position to be used in a lot of places.
|
|
|
|
This brings it up to date after e7cf3911104f.
|
|
There is absolutely nothing useful that an indexing algorithm can do
with the opaque DataTemplate object.
|
|
This is a more sensible non-indexer-specific and non-Xray-specific
replacement for --pinkIndexer-override-photon-energy
|
|
This tells Mosflm not to try to load environ.def and defaults.def. We
don't need either.
|
|
These needed to be kept up to date with a call to map_all_peaks every
time anything changed - wavelength, detector position etc. Not doing so
has already led to bugs in another branch, and probably already causes
problems on this branch.
This patch eliminates the rx,ry,rz completely. Anyone who needs
reciprocal space coordinates for a peak is now responsible for calling
detgeom_transform_coords themselves.
|
|
This gives a huge speed improvement, without sacrificing very much in
indexing rate.
|
|
|