Age | Commit message (Collapse) | Author | |
---|---|---|---|
2023-02-17 | asdf: Restrict domain for search for peaks in frequency graph | Alexandra Tolstikova | |
Previously, it was possible for the search to run over the part of the array initialised by FFTW. | |||
2023-01-16 | asdf: Avoid integer overflow with number of triplets | Thomas White | |
Co-authored-by: Alexandra Tolstikova <alexandra.tolstikova@desy.de> Fixes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/76 | |||
2022-09-21 | asdf: Add fast mode | Alexandra Tolstikova | |
This adds an optional fast mode for asdf indexing, which is around 3 times faster with only a few percent lower success rate. | |||
2022-03-18 | Formatting | Thomas White | |
2022-01-27 | correct a simple typo | Jerome Kieffer | |
2021-09-07 | TakeTwo: Check for empty observed vector list | Thomas White | |
2021-08-20 | Mosflm: Add -n option when probing | Thomas White | |
2021-07-23 | TakeTwo: Remove unused variables | Thomas White | |
2021-07-23 | TakeTwo: Avoid potential NULL dereference on error path | Thomas White | |
2021-07-23 | asdf: Rename shadow variable | Thomas White | |
2021-07-22 | Clean up shadowed variables | Thomas White | |
2021-07-21 | asdf: Remove unnecessary check | Thomas White | |
'changed' is initialised to zero, so there's no way this check can fail. | |||
2021-07-21 | Reduce variable scope where possible | Thomas White | |
2021-07-21 | Make sure that memory gets freed on realloc failure | Thomas White | |
2021-07-21 | Add missing cleanup on error paths | Thomas White | |
2021-07-14 | PinkIndexer: replace long formula with modulus() | Thomas White | |
2021-07-14 | Make all the indexer-specific option structures non-opaque | Thomas White | |
Making them opaque seemed like a nice idea, because all the indexers could take care of their own command-line arguments. However, it doesn't work at all when indexing is run via the API. | |||
2021-05-17 | Resolve FIXMEs and TODOs | Thomas White | |
Prompted by the article linked below, for each FIXME/TODO I've either referenced an issue in the tracker, or removed it if it's not worth fixing. https://schleiss.io/plotting-source-code-todos-for-open-source-projects | |||
2021-05-17 | Mosflm: Remove dead code | Thomas White | |
This removes some old stub code. There doesn't seem to be a big need for doing what the FIXME suggests. | |||
2021-04-27 | Rename libcrystfel's config.h to libcrystfel-config.h | Thomas White | |
This removes the big potential for confusion, which has happened several times (see e.g. 095cbebaf6). It also fixes in-tree builds with CMake (but seriously, always use out-of-tree builds). Fixes #2. | |||
2021-04-19 | Move file_exists to utils (and eliminate several duplicates) | Thomas White | |
2021-04-01 | FromFile indexer, stream2sol.py: Remove space escaping | Thomas White | |
This isn't necessary after all, for the same reason that im-sandbox doesn't need escaping: it can count off the fields where spaces aren't allowed, and anything left is the filename. I was over-thinking things. | |||
2021-03-31 | FromFile indexer, stream2sol.py: Handle spaces in filename | Thomas White | |
2021-03-31 | FromFile indexer, stream2sol.py: Add/update copyright comments | Thomas White | |
2021-03-25 | indexamajig: Add --camera-length-estimate | Thomas White | |
Unfortunately, PinkIndexer needs the real camera length for its centre refinement. Giving a fake value and scaling the resulting shift does not work - the indexing rate drops with even a small error. Ideally, this would work in the same way as --wavelength-estimate, by using a static value from the geometry file if it's given. However, this is rather complicated to implement because of the way all the units stuff is implemented. Therefore, this is left as an improvement for the future. | |||
2021-03-25 | PinkIndexer: fix conversion of detector shift | Thomas White | |
2021-03-25 | Fussiness | Thomas White | |
The FIXMEs have both already been fixed. | |||
2021-03-22 | FromFile indexer: Fix prototype | Thomas White | |
2021-03-19 | FromFile indexer: add copyright notice | Thomas White | |
There is presumably an MPSD that also needs to be added. | |||
2021-03-19 | FromFile indexer: Take account of working directory | Thomas White | |
2021-03-19 | FromFile indexer: New parser and simplification of code | Thomas White | |
Significant change: the solution file must now come with the lattice type, centering and (if applicable) unique axis information at the end of each line, e.g. 'cI' (cubic I), 'mAb' (monoclinic A, unique axis b). | |||
2021-03-19 | FromFile indexer: Option processing | Thomas White | |
This give FromFile its own private command-lien option processing, like the other indexers. It removes the ability to auto-generate the solution filename, but I don't think there's a way to do that without breaking abstractions. | |||
2021-03-12 | FromFile indexer: Add skeleton cleanup procedure | Thomas White | |
2021-03-12 | FromFile indexer: Update for new event ID in image structure | Thomas White | |
2021-03-12 | FromFile indexer: Remove unnecessary casting/memset | Thomas White | |
2021-03-12 | FromFile indexer: Remove getcwd() | Thomas White | |
It's only used for some error messages, and it doesn't compile anyway. | |||
2021-03-12 | FromFile indexer: Remove update_detector | Thomas White | |
Everything should use the per-crystal detector shift now. | |||
2021-03-12 | FromFile indexer: Add missing semicolons | Thomas White | |
2021-03-12 | FromFile indexer: Strip trailing whitespace and sort out formatting | Thomas White | |
2021-03-12 | FromFile indexer: Move to libcrystfel/src/indexers | Thomas White | |
Also adds to meson.build | |||
2021-03-11 | indexamajig: Add --max-indexer-threads | Thomas White | |
This is a more general replacement for --pinkIndexer-thread-count. | |||
2021-03-11 | PinkIndexer: Allocate peak lists when indexing | Thomas White | |
There doesn't seem to be any point in allocating them earlier, except to make space for some nice bugs. | |||
2021-03-11 | PinkIndexer: Remove unnecessary cast | Thomas White | |
2021-03-11 | PinkIndexer: Remove wide bandwidth stuff | Thomas White | |
This will return later in a more centralised form, if we decide to work further on wide bandwidth. | |||
2021-03-11 | PinkIndexer: Use fake camera length for detector refinement | Thomas White | |
... and calculate the real value afterwards, checking that the detector is really flat enough for it to work. | |||
2021-03-11 | PinkIndexer: Remove custom indexing checks | Thomas White | |
These conflict badly with CrystFEL's own checks, creating a horrible user and developer experience. Later, if we want to handle wide bandwidth beams, we will improve the central CrystFEL checks to support it. | |||
2021-03-11 | detgeom_transform_coords: Take an additional detector shift | Thomas White | |
This allows the refined detector position to be used in a lot of places. | |||
2021-03-11 | Update copyright dates in libcrystfel/src/indexers | Thomas White | |
2021-03-11 | PinkIndexer: Don't use ImageFeature->rx,ry,rz | Thomas White | |
This brings it up to date after e7cf3911104f. | |||
2021-03-11 | setup_indexing: Remove dtempl | Thomas White | |
There is absolutely nothing useful that an indexing algorithm can do with the opaque DataTemplate object. |